Add support for token-based usage metrics. #8757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Token measurement is broken down by modaliy, with separate counters for image, audio, etc. Tests are in version 6.*, so this change also includes bumping update_responses.sh
🦋 Changeset detectedLatest commit: 6f90b2e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
hsubox76
reviewed
Feb 6, 2025
There was a problem hiding this comment.
Looks good, just need to add a changeset - yarn changeset, choose "@firebase/vertexai" (should already be selected) and "firebase" (won't be selected) and select "minor" for both. If you can't select "firebase" that's ok, you can also add 'firebase': minor manually in the resulting changeset file after it's created.
hsubox76
reviewed
Feb 13, 2025
| @@ -213,4 +228,6 @@ export interface CountTokensResponse { | |||
| * from the request. | |||
| */ | |||
| totalBillableCharacters?: number; | |||
|
|
|||
| promptTokensDetails?: ModalityTokenCount[]; | |||
There was a problem hiding this comment.
Do we want docs on this property? If so, add it in the same comment format as the two other properties above.
There was a problem hiding this comment.
Added, thanks!
BTW, why are enums shown as (undocumented) in the generated .md file?
dlarocque
reviewed
Feb 18, 2025
|
Oh sorry, can you run |
rlazo
requested review from
a team,
avolkovi,
sam-gc and
yuchenshi
as code owners
Changeset File Check ✅
|
rlazo
commented
Feb 19, 2025
| // Point it to your entry point d.ts file. |
There was a problem hiding this comment.
BTW, I needed to make this change otherwise the tool wouldn't run correctly. Should I leave it in the PR or remove it?
There was a problem hiding this comment.
Sorry about this again, this might be because of an updated rollup plugin dependency that was merged after you made this branch. The old plugin would write to the path you've updated it to, the new version writes to the new path - this change is causing the docgen step to fail in CI now.
Locally can you try deleting node_modules and reinstalling deps?
// in the root of the repo
rm -fr node_modules
yarn
// try docgen again
yarn docgen:all
rachelsaunders
requested changes
Feb 24, 2025
Co-authored-by: rachelsaunders <[email protected]>
rachelsaunders
requested changes
Feb 24, 2025
docs-devsite/vertexai.md
Outdated
| | Member | Value | Description | | ||
| | --- | --- | --- | | ||
| | AUDIO | <code>"AUDIO"</code> | Audio. | | ||
| | DOCUMENT | <code>"DOCUMENT"</code> | Document, e.g. PDF. | |
There was a problem hiding this comment.
Suggested change
| | DOCUMENT | <code>"DOCUMENT"</code> | Document, e.g. PDF. | | |
| | DOCUMENT | <code>"DOCUMENT"</code> | Document (for example, PDF). | |
rachelsaunders
approved these changes
Feb 24, 2025
hsubox76
approved these changes
Feb 24, 2025
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Token measurement is broken down by modaliy, with separate counters for image, audio, etc.
Tests are in version 6.*, so this change also includes bumping update_responses.sh
Internal API proposal doc: go/firebase-vertex-token-modality-api